Conversation
sdruskat
assigned
knarrff,
led02,
jlinx,
StephanJanosch,
ClaireWyatt and
BFrit and unassigned
knarrff,
led02,
jlinx,
StephanJanosch,
ClaireWyatt and
BFrit
Member
|
Seems fine from my side. I am not regular conda user though |
Contributor
|
Might make sense to pin or add an upper bound to the versions (probably at least for ruby?), such that you don't risk that jekyll and the ruby version go out of sync. |
Contributor
Author
True. I've pinned I've also removed the declarations of transitive dependencies for jekyll in the Gemfile, as these are pulled during |
Contributor
Author
|
Happy for another review, @BeastyBlacksmith. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds another option for installing the required dependencies for local builds.
.ymlfile declares the required dependencies in an OS-independent way.README.mdhas been updated to document its use.